Fix support for custom visualizations #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Arguments no longer require a source if the type is specified to be custom * If no source is provided for a custom visualization, it will no longer be provided to the Python service
|
/assign @IronPan |
…e custom visualizations
|
/hold |
ajchili
changed the title
|
/hold cancel |
neuromage
reviewed
Aug 27, 2019
IronPan
reviewed
Aug 27, 2019
Arguments are no longer manually converted to command line arguments to be passed to the Python service. Instead, they are converted to x-www-form-urlencoded arguments which is sent to the Python service and then converted to a dictionary by the Python service.
ajchili
added a commit
to ajchili/pipelines
that referenced
this pull request
Aug 27, 2019
kubeflow#1951 changes how arguments are passed from the API server to the Python service. This now allows for multi-line comment support.
|
/retest |
neuromage
reviewed
Aug 27, 2019
|
/test kubeflow-pipeline-sample-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipeline-sample-test |
ajchili
added a commit
to ajchili/pipelines
that referenced
this pull request
Aug 28, 2019
* Change how arguments are checked and provided for Python service * Arguments no longer require a source if the type is specified to be custom * If no source is provided for a custom visualization, it will no longer be provided to the Python service * Added unit test to test that an empty source can be provided alongside custom visualizations * Added support for custom code to be used to generate visualizations within Python service * Added unit tests to cover support of custom visualizations * Fixed logic that handles source addition and validation in API * Formatted visualization_server_test.go * Moved self.maxDiff to setup function * Removed unused import * Simplified how arguments are passed from API to Python service Arguments are no longer manually converted to command line arguments to be passed to the Python service. Instead, they are converted to x-www-form-urlencoded arguments which is sent to the Python service and then converted to a dictionary by the Python service. * Made @staticmethods private functions
ajchili
added a commit
to ajchili/pipelines
that referenced
this pull request
Aug 29, 2019
kubeflow#1951 changes how arguments are passed from the API server to the Python service. This now allows for multi-line comment support.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Aug 30, 2019
* Added developer_guide.md for Python based visualizations * Changed md file name to be README and added link to documentation page * Updated README.md to match syntax of #1878 * Added architecture and known limitations sections to documentation * Addressed PR comments * Address offline feedback from @SinaChavoshi * Removed limitation #1951 changes how arguments are passed from the API server to the Python service. This now allows for multi-line comment support. * Addressed PR comments
This was referenced Jan 15, 2020
1 task
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Rename KF prefixed classes Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Update model servers Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Missed renaming Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Missed renaming Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Fix merge Signed-off-by: Mark Winter <mark.winter@navercorp.com> * Fix merge Signed-off-by: Mark Winter <mark.winter@navercorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is